fix(markdown): accept blank line after admonition header#3102
Open
leno23 wants to merge 2 commits into
Open
Conversation
Merge pulldown-cmark blockquote events split when an admonition header is followed by a blank `>` line, matching GitHub GFM and surviving Markdown prettifiers (pulldown-cmark rust-lang#890). Fixes rust-lang#3066. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supports GFM admonitions with a blank
>line after the header:pulldown-cmark splits this into two blockquotes (see pulldown-cmark#890); this merges those events so mdBook renders a proper admonition. The syntax matches GitHub and survives Markdown prettifiers that insert a blank line after headings.
Implementation adapted from the iterator adapter proposed in #3066.
new_cmark_parsernow returns an opaqueMarkdownParserstruct (still implementsIterator<Item = Event>) instead ofpulldown_cmark::Parserdirectly.Fixes #3066.
Test plan
markdown/admonitionscargo test -p mdbook --test testsuite(110 passed)Made with Cursor