Skip to content

deprecate the <int type>_{MIN,MAX} constants #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
telcharr wants to merge 3 commits into
base: main
Choose a base branch
from
Open

deprecate the <int type>_{MIN,MAX} constants #5404

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cf9415
swap crate's INT_MIN/MAX with c_int::MIN/MAX
telcharr Aug 9, 2026
3fba53b
deprecate the integer type MIN/MAX constants
telcharr Aug 11, 2026
57412b6
derive deprecated constants from their types
telcharr Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/fuchsia/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,7 +1183,9 @@ cfg_if! {

pub const HOST_NAME_MAX: c_int = 255;

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -1 - 0x7fffffff;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 0x7fffffff;

@tgross35 tgross35 Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this, would you mind changing the values to what we're suggesting to replace? E.g. pub const INT_MIN: c_int = c_int::MAX;

That way tests should pick up any cases where they don't match up.

@telcharr telcharr Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I did move some values on 64-bit hurd, which I think were just wrong before. The *_FAST16/32 ones are c_long/ulong on that target and the pointer-width ones are isize/usize but all were written with 32-bit literals. One thing I'm a bit less sure on is that INTPTR_MIN/MAX and PTRDIFF_MIN/MAX needed their declared type moved to intptr_t/ptrdiff_t for this to compile since __intptr_t is c_long and won't unify with isize. If you'd rather I left those two alone let me know.


pub const SIG_DFL: sighandler_t = 0 as sighandler_t;
Expand Down
14 changes: 14 additions & 0 deletions src/new/qurt/limits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,37 @@ use crate::prelude::*;

// Character properties
pub const CHAR_BIT: c_uint = 8;
#[deprecated(since = "0.2.190", note = "Use `c_char::MAX` instead.")]
pub const CHAR_MAX: c_char = 255; // unsigned char on Hexagon
#[deprecated(since = "0.2.190", note = "Use `c_char::MIN` instead.")]
pub const CHAR_MIN: c_char = 0;
#[deprecated(since = "0.2.190", note = "Use `c_schar::MAX` instead.")]
pub const SCHAR_MAX: i8 = 127;
#[deprecated(since = "0.2.190", note = "Use `c_schar::MIN` instead.")]
pub const SCHAR_MIN: i8 = -128;
#[deprecated(since = "0.2.190", note = "Use `c_uchar::MAX` instead.")]
pub const UCHAR_MAX: c_uchar = 255;

// Integer properties
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483647 - 1;
#[deprecated(since = "0.2.190", note = "Use `c_uint::MAX` instead.")]
pub const UINT_MAX: c_uint = 4294967295;

#[deprecated(since = "0.2.190", note = "Use `c_long::MAX` instead.")]
pub const LONG_MAX: c_long = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `c_long::MIN` instead.")]
pub const LONG_MIN: c_long = -2147483647 - 1;
#[deprecated(since = "0.2.190", note = "Use `c_ulong::MAX` instead.")]
pub const ULONG_MAX: c_ulong = 4294967295;

#[deprecated(since = "0.2.190", note = "Use `c_short::MAX` instead.")]
pub const SHRT_MAX: c_short = 32767;
#[deprecated(since = "0.2.190", note = "Use `c_short::MIN` instead.")]
pub const SHRT_MIN: c_short = -32768;
#[deprecated(since = "0.2.190", note = "Use `c_ushort::MAX` instead.")]
pub const USHRT_MAX: c_ushort = 65535;

// POSIX Limits
Expand Down
2 changes: 2 additions & 0 deletions src/sgx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@ pub type intptr_t = isize;
pub type uintptr_t = usize;
pub type ssize_t = isize;

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;
2 changes: 2 additions & 0 deletions src/solid/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ s! {
}
}

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;

pub const EXIT_FAILURE: c_int = 1;
Expand Down
2 changes: 2 additions & 0 deletions src/switch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,7 @@ pub type ssize_t = isize;
pub type off_t = i64;
pub type wchar_t = u32;

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;
37 changes: 37 additions & 0 deletions src/unix/hurd/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2634,42 +2634,79 @@ pub const TCP_REPAIR_OFF: c_int = 0;
pub const TCP_REPAIR_OFF_NO_WP: c_int = -1;

// stdint.h
#[deprecated(since = "0.2.190", note = "Use `i8::MIN` instead.")]
pub const INT8_MIN: i8 = -128;
#[deprecated(since = "0.2.190", note = "Use `i16::MIN` instead.")]
pub const INT16_MIN: i16 = -32768;
#[deprecated(since = "0.2.190", note = "Use `i32::MIN` instead.")]
pub const INT32_MIN: i32 = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `i8::MAX` instead.")]
pub const INT8_MAX: i8 = 127;
#[deprecated(since = "0.2.190", note = "Use `i16::MAX` instead.")]
pub const INT16_MAX: i16 = 32767;
#[deprecated(since = "0.2.190", note = "Use `i32::MAX` instead.")]
pub const INT32_MAX: i32 = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `u8::MAX` instead.")]
pub const UINT8_MAX: u8 = 255;
#[deprecated(since = "0.2.190", note = "Use `u16::MAX` instead.")]
pub const UINT16_MAX: u16 = 65535;
#[deprecated(since = "0.2.190", note = "Use `u32::MAX` instead.")]
pub const UINT32_MAX: u32 = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `int_least8_t::MIN` instead.")]
pub const INT_LEAST8_MIN: int_least8_t = -128;
#[deprecated(since = "0.2.190", note = "Use `int_least16_t::MIN` instead.")]
pub const INT_LEAST16_MIN: int_least16_t = -32768;
#[deprecated(since = "0.2.190", note = "Use `int_least32_t::MIN` instead.")]
pub const INT_LEAST32_MIN: int_least32_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `int_least8_t::MAX` instead.")]
pub const INT_LEAST8_MAX: int_least8_t = 127;
#[deprecated(since = "0.2.190", note = "Use `int_least16_t::MAX` instead.")]
pub const INT_LEAST16_MAX: int_least16_t = 32767;
#[deprecated(since = "0.2.190", note = "Use `int_least32_t::MAX` instead.")]
pub const INT_LEAST32_MAX: int_least32_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `uint_least8_t::MAX` instead.")]
pub const UINT_LEAST8_MAX: uint_least8_t = 255;
#[deprecated(since = "0.2.190", note = "Use `uint_least16_t::MAX` instead.")]
pub const UINT_LEAST16_MAX: uint_least16_t = 65535;
#[deprecated(since = "0.2.190", note = "Use `uint_least32_t::MAX` instead.")]
pub const UINT_LEAST32_MAX: uint_least32_t = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `int_fast8_t::MIN` instead.")]
pub const INT_FAST8_MIN: int_fast8_t = -128;
#[deprecated(since = "0.2.190", note = "Use `int_fast16_t::MIN` instead.")]
pub const INT_FAST16_MIN: int_fast16_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `int_fast32_t::MIN` instead.")]
pub const INT_FAST32_MIN: int_fast32_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `int_fast8_t::MAX` instead.")]
pub const INT_FAST8_MAX: int_fast8_t = 127;
#[deprecated(since = "0.2.190", note = "Use `int_fast16_t::MAX` instead.")]
pub const INT_FAST16_MAX: int_fast16_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `int_fast32_t::MAX` instead.")]
pub const INT_FAST32_MAX: int_fast32_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `uint_fast8_t::MAX` instead.")]
pub const UINT_FAST8_MAX: uint_fast8_t = 255;
#[deprecated(since = "0.2.190", note = "Use `uint_fast16_t::MAX` instead.")]
pub const UINT_FAST16_MAX: uint_fast16_t = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `uint_fast32_t::MAX` instead.")]
pub const UINT_FAST32_MAX: uint_fast32_t = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `intptr_t::MIN` instead.")]
pub const INTPTR_MIN: __intptr_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `intptr_t::MAX` instead.")]
pub const INTPTR_MAX: __intptr_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `uintptr_t::MAX` instead.")]
pub const UINTPTR_MAX: usize = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `ptrdiff_t::MIN` instead.")]
pub const PTRDIFF_MIN: __ptrdiff_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `ptrdiff_t::MAX` instead.")]
pub const PTRDIFF_MAX: __ptrdiff_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const SIG_ATOMIC_MIN: __sig_atomic_t = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const SIG_ATOMIC_MAX: __sig_atomic_t = 2147483647;
#[deprecated(since = "0.2.190", note = "Use `size_t::MAX` instead.")]
pub const SIZE_MAX: usize = 4294967295;
#[deprecated(since = "0.2.190", note = "Use `wint_t::MIN` instead.")]
pub const WINT_MIN: wint_t = 0;
#[deprecated(since = "0.2.190", note = "Use `wint_t::MAX` instead.")]
pub const WINT_MAX: wint_t = 4294967295;
pub const INT8_WIDTH: usize = 8;
pub const UINT8_WIDTH: usize = 8;
Expand Down
14 changes: 7 additions & 7 deletions src/unix/linux_like/android/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1977,7 +1977,7 @@ pub const NF_BR_POST_ROUTING: c_int = 4;
pub const NF_BR_BROUTING: c_int = 5;
pub const NF_BR_NUMHOOKS: c_int = 6;

pub const NF_BR_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_BR_PRI_FIRST: c_int = c_int::MIN;
pub const NF_BR_PRI_NAT_DST_BRIDGED: c_int = -300;
pub const NF_BR_PRI_FILTER_BRIDGED: c_int = -200;
pub const NF_BR_PRI_BRNF: c_int = 0;
Expand All @@ -1987,7 +1987,7 @@ pub const NF_BR_PRI_NAT_SRC: c_int = 300;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_BR_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_BR_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv4.h
pub const NF_IP_PRE_ROUTING: c_int = 0;
Expand All @@ -1997,7 +1997,7 @@ pub const NF_IP_LOCAL_OUT: c_int = 3;
pub const NF_IP_POST_ROUTING: c_int = 4;
pub const NF_IP_NUMHOOKS: c_int = 5;

pub const NF_IP_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_IP_PRI_FIRST: c_int = c_int::MIN;
pub const NF_IP_PRI_RAW_BEFORE_DEFRAG: c_int = -450;
pub const NF_IP_PRI_CONNTRACK_DEFRAG: c_int = -400;
pub const NF_IP_PRI_RAW: c_int = -300;
Expand All @@ -2010,11 +2010,11 @@ pub const NF_IP_PRI_SECURITY: c_int = 50;
pub const NF_IP_PRI_NAT_SRC: c_int = 100;
pub const NF_IP_PRI_SELINUX_LAST: c_int = 225;
pub const NF_IP_PRI_CONNTRACK_HELPER: c_int = 300;
pub const NF_IP_PRI_CONNTRACK_CONFIRM: c_int = crate::INT_MAX;
pub const NF_IP_PRI_CONNTRACK_CONFIRM: c_int = c_int::MAX;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_IP_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_IP_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv6.h
pub const NF_IP6_PRE_ROUTING: c_int = 0;
Expand All @@ -2024,7 +2024,7 @@ pub const NF_IP6_LOCAL_OUT: c_int = 3;
pub const NF_IP6_POST_ROUTING: c_int = 4;
pub const NF_IP6_NUMHOOKS: c_int = 5;

pub const NF_IP6_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_IP6_PRI_FIRST: c_int = c_int::MIN;
pub const NF_IP6_PRI_RAW_BEFORE_DEFRAG: c_int = -450;
pub const NF_IP6_PRI_CONNTRACK_DEFRAG: c_int = -400;
pub const NF_IP6_PRI_RAW: c_int = -300;
Expand All @@ -2040,7 +2040,7 @@ pub const NF_IP6_PRI_CONNTRACK_HELPER: c_int = 300;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_IP6_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_IP6_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv6/ip6_tables.h
pub const IP6T_SO_ORIGINAL_DST: c_int = 80;
Expand Down
14 changes: 7 additions & 7 deletions src/unix/linux_like/linux/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,7 +1780,7 @@ pub const NF_BR_POST_ROUTING: c_int = 4;
pub const NF_BR_BROUTING: c_int = 5;
pub const NF_BR_NUMHOOKS: c_int = 6;

pub const NF_BR_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_BR_PRI_FIRST: c_int = c_int::MIN;
pub const NF_BR_PRI_NAT_DST_BRIDGED: c_int = -300;
pub const NF_BR_PRI_FILTER_BRIDGED: c_int = -200;
pub const NF_BR_PRI_BRNF: c_int = 0;
Expand All @@ -1790,7 +1790,7 @@ pub const NF_BR_PRI_NAT_SRC: c_int = 300;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_BR_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_BR_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv4.h
pub const NF_IP_PRE_ROUTING: c_int = 0;
Expand All @@ -1800,7 +1800,7 @@ pub const NF_IP_LOCAL_OUT: c_int = 3;
pub const NF_IP_POST_ROUTING: c_int = 4;
pub const NF_IP_NUMHOOKS: c_int = 5;

pub const NF_IP_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_IP_PRI_FIRST: c_int = c_int::MIN;
pub const NF_IP_PRI_RAW_BEFORE_DEFRAG: c_int = -450;
pub const NF_IP_PRI_CONNTRACK_DEFRAG: c_int = -400;
pub const NF_IP_PRI_RAW: c_int = -300;
Expand All @@ -1813,11 +1813,11 @@ pub const NF_IP_PRI_SECURITY: c_int = 50;
pub const NF_IP_PRI_NAT_SRC: c_int = 100;
pub const NF_IP_PRI_SELINUX_LAST: c_int = 225;
pub const NF_IP_PRI_CONNTRACK_HELPER: c_int = 300;
pub const NF_IP_PRI_CONNTRACK_CONFIRM: c_int = crate::INT_MAX;
pub const NF_IP_PRI_CONNTRACK_CONFIRM: c_int = c_int::MAX;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_IP_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_IP_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv6.h
pub const NF_IP6_PRE_ROUTING: c_int = 0;
Expand All @@ -1827,7 +1827,7 @@ pub const NF_IP6_LOCAL_OUT: c_int = 3;
pub const NF_IP6_POST_ROUTING: c_int = 4;
pub const NF_IP6_NUMHOOKS: c_int = 5;

pub const NF_IP6_PRI_FIRST: c_int = crate::INT_MIN;
pub const NF_IP6_PRI_FIRST: c_int = c_int::MIN;
pub const NF_IP6_PRI_RAW_BEFORE_DEFRAG: c_int = -450;
pub const NF_IP6_PRI_CONNTRACK_DEFRAG: c_int = -400;
pub const NF_IP6_PRI_RAW: c_int = -300;
Expand All @@ -1843,7 +1843,7 @@ pub const NF_IP6_PRI_CONNTRACK_HELPER: c_int = 300;

/// Constants may change across releases. See the [usage guidelines](crate#usage-guidelines)
/// for details.
pub const NF_IP6_PRI_LAST: c_int = crate::INT_MAX;
pub const NF_IP6_PRI_LAST: c_int = c_int::MAX;

// linux/netfilter_ipv6/ip6_tables.h
pub const IP6T_SO_ORIGINAL_DST: c_int = 80;
Expand Down
2 changes: 2 additions & 0 deletions src/unix/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ cfg_if! {
}
}

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;

pub const SIG_DFL: sighandler_t = 0 as sighandler_t;
Expand Down
4 changes: 3 additions & 1 deletion src/vxworks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,10 @@ pub const EAI_SERVICE: c_int = 9;
pub const EAI_SOCKTYPE: c_int = 10;
pub const EAI_SYSTEM: c_int = 11;

#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 0x7fffffff;
pub const INT_MIN: c_int = -INT_MAX - 1;
#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -0x7fffffff - 1;

// FIXME(vxworks): This is not defined in vxWorks, but we have to define it here
// to make the building pass for getrandom and std
Expand Down
2 changes: 2 additions & 0 deletions src/windows/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,9 @@ s! {
}
}

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;

pub const EXIT_FAILURE: c_int = 1;
Expand Down
2 changes: 2 additions & 0 deletions src/xous.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,7 @@ pub type ssize_t = isize;
pub type off_t = i64;
pub type wchar_t = u32;

#[deprecated(since = "0.2.190", note = "Use `c_int::MIN` instead.")]
pub const INT_MIN: c_int = -2147483648;
#[deprecated(since = "0.2.190", note = "Use `c_int::MAX` instead.")]
pub const INT_MAX: c_int = 2147483647;