Forbid unprefixed SHAs for toolchains#723
Merged
Merged
Conversation
Member
|
@bors r+ This seems reasonable to me. |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Mar 31, 2024
Forbid unprefixed SHAs for toolchains This PR forbids unprefixed SHAs for toolchain arguments, to avoid crater hanging when they appear. I'm not sure this is fully valid though: I don't know if SHAs could appear in a `Toolchain`'s name (and `RustwideToolchain::dist()`) without being an error 😓. This commonly happens with `rustup-toolchain-install-master` but I don't know if a similar situation could arise within common crater usage. CI will surely fail: some of the used dependencies are broken on nightly right now, and clippy emits warnings -- both issues are fixed in #722. <sub>(this is [for](rust-lang/rust#122230 (comment)) `@oli-obk` and [for](rust-lang/rust#122502 (comment)) `@compiler-errors)</sub>`
Contributor
|
💔 Test failed - checks-actions |
Member
|
@bors r+ |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
1 similar comment
Contributor
|
☀️ Test successful - checks-actions |
Contributor
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR forbids unprefixed SHAs for toolchain arguments, to avoid crater hanging when they appear.
I'm not sure this is fully valid though: I don't know if SHAs could appear in a
Toolchain's name (andRustwideToolchain::dist()) without being an error 😓. This commonly happens withrustup-toolchain-install-masterbut I don't know if a similar situation could arise within common crater usage.CI will surely fail: some of the used dependencies are broken on nightly right now, and clippy emits warnings -- both issues are fixed in #722.
(this is for @oli-obk and for @compiler-errors)