Skip to content

Make optimize_attribute conditional on libstd #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisDenton merged 1 commit into from
May 28, 2026
+11 −1
Merged

Make optimize_attribute conditional on libstd #752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/as-if-std/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,17 @@
// submodule into the standard library. We try to set this crate up similarly
// to the standard library itself to minimize the likelihood of issues when
// updating the `backtrace` crate.
#![feature(optimize_attribute)]
#![cfg_attr(
// Only used by the gimli backend, see src/symbolize/mod.rs
all(
backtrace_in_libstd,
feature = "backtrace",
any(unix, all(windows, target_env = "gnu")),
not(target_vendor = "uwp"),
Copy link
Copy Markdown
Member

@workingjubilee workingjubilee May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...is windows with gnu and UWP a coherent concept?

anyway the not obtains so we're fine regardless.

Copy link
Copy Markdown
Member Author

@ChrisDenton ChrisDenton May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. I mean, hypothetically at least. We have an x86_64-uwp-windows-gnu target but idk how well all these targets are maintained. But tbh I don't know how well any of the UWP targets are maintained or even if they make any sense. I know the msvc one is used by at least one person because they complain when I break it (though not immediately).

not(target_os = "emscripten"),
),
feature(optimize_attribute)
)]
#![no_std]

extern crate alloc;
Expand Down
Loading