Skip to content

Fix getnetworkhashps return type in docs #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcharding merged 1 commit into from
May 21, 2026
Merged

Fix getnetworkhashps return type in docs #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_test/tests/mining.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ fn mining__get_mining_info() {
fn mining__get_network_hash_ps() {
let node = BitcoinD::with_wallet(Wallet::Default, &[]);
node.fund_wallet();
let _ = node.client.get_network_hash_ps().expect("rpc");
let _: f64 = node.client.get_network_hash_ps().expect("rpc");
}

#[test]
Expand Down
2 changes: 1 addition & 1 deletion types/src/v17/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//!
Expand Down
2 changes: 1 addition & 1 deletion types/src/v18/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v19/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v20/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v21/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v22/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v23/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v24/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v25/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
//! | submitheader | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v26/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | getprioritisedtransactions | version + model | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v27/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | getprioritisedtransactions | version + model | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v28/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | getprioritisedtransactions | version + model | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v29/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | getprioritisedtransactions | version + model | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion types/src/v30/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
//! |:-----------------------------------|:---------------:|:--------------------------------------:|
//! | getblocktemplate | version + model | |
//! | getmininginfo | version + model | |
//! | getnetworkhashps | returns boolean | |
//! | getnetworkhashps | returns numeric | |
//! | getprioritisedtransactions | version + model | |
//! | prioritisetransaction | returns boolean | |
//! | submitblock | returns nothing | |
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v18.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v19.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v20.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v21.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v22.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v23.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v24.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v25.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_bool("prioritisetransaction", "prioritise_transaction"),
Method::new_nothing("submitblock", "submit_block"),
Method::new_nothing("submitheader", "submit_header"),
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v26.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_modelled(
"getprioritisedtransactions",
"GetPrioritisedTransactions",
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v27.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_modelled(
"getprioritisedtransactions",
"GetPrioritisedTransactions",
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v28.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_modelled(
"getprioritisedtransactions",
"GetPrioritisedTransactions",
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v29.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_modelled(
"getprioritisedtransactions",
"GetPrioritisedTransactions",
Expand Down
2 changes: 1 addition & 1 deletion verify/src/method/v30.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pub const METHODS: &[Method] = &[
// mining
Method::new_modelled("getblocktemplate", "GetBlockTemplate", "get_block_template"),
Method::new_modelled("getmininginfo", "GetMiningInfo", "get_mining_info"),
Method::new_nothing("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_numeric("getnetworkhashps", "get_network_hashes_per_second"),
Method::new_modelled(
"getprioritisedtransactions",
"GetPrioritisedTransactions",
Expand Down
Loading