Skip to content

bug: fix hf-token being passed in engineargs #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
velaraptor-runpod merged 2 commits into from
May 1, 2026
Merged

bug: fix hf-token being passed in engineargs #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bb8df7
bug: fix hf-token being passed in engineargs
velaraptor-runpod May 1, 2026
73f030a
Merge branch 'main' into bug/281-hf-token
velaraptor-runpod May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/engine_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,16 @@ def _convert_env_value_to_field_type(value: str, field_name: str, field_type: ty
if type(None) in (args or ()):
return None
raise ValueError("empty value not allowed for non-optional field")

# Union[bool, str, ...]: only coerce to bool for unambiguous literals;
# otherwise preserve the string (e.g. hf_token="hf_abc..." must stay a str).
if get_origin(field_type) is not None:
union_types = [a for a in (get_args(field_type) or ()) if a is not type(None)]
if bool in union_types and str in union_types:
if str(val).lower() in ("true", "false", "1", "0", "yes", "no", "on", "off"):
return str(val).lower() in ("true", "1", "yes", "on")
return str(val)

effective_type = _resolve_field_type(field_type)
# bool
if effective_type is bool:
Expand Down
Loading