Repository navigation
Conversation
vavo
marked this pull request as ready for review
September 28, 2026 08:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Return ComfyUI native
videosand VideoHelperSuitegifsoutputs inoutput.videosas base64 or S3 URLs while preserving the existingoutput.imagesresponse. Video uploads use detected MIME types, clean up temporary files, and honorBUCKET_PREFIX/{job_id}when configured.The output handling tests exercise the handler against a local
/viewHTTP server and cover base64, S3 MIME/prefix metadata, and cleanup. The full 31-test Python suite passed. The Docker image build was not run because the local Docker daemon was unavailable.This overlaps the earlier open PR #133, whose review requested rebase, correct MIME type, base64 support, and temporary-file cleanup. This draft includes those fixes and native
videosoutput handling.Issues closed
Closes #232
Changeset
Generated with
pnpm changesetas a minor release.