Add Overheads Reworked - #14109
Open
Swamisama wants to merge 1 commit into
Open
Conversation
|
New plugin |
|
Internal use only: Reviewer details Maintainer details |
Swamisama
marked this pull request as ready for review
July 21, 2026 02:21
Contributor
|
My only concern would be the tile highlight in PVP cases, but I suppose that's irrelevant if there are plugins that already hide the local player so you can see the player standing under you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overheads Reworked
Replaces the large overhead protection-prayer bubbles with a subtle display. In
8-man raids the vanilla bubbles stack up and cover the ground tiles you need to
see; this trades them for an underfoot tile tint (the default) while redrawing
the 2D elements you still want.
Player-only by design. NPCs keep their vanilla overheads completely
untouched — non-player renderables are passed through before any prayer state is
even read.
What it does
for yourself, party members, and other players.
outline, and/or a compact copy of the original overhead icon. These combine.
individually toggleable with a height offset.
Only while praying(default on) limits hiding to players who currently havean overhead icon, so non-praying players are untouched.
Replacecheckbox,off by default — their vanilla icons stay intact unless explicitly opted into.
How it works
A
RenderCallbackregistered withRenderCallbackManageris consulted for eachrenderable per frame. Returning
falsefromaddEntityon a player'sdrawingUIpass hides that player's entire 2D block — chat, health bar,hitsplats, and prayer bubble together, since the API exposes no per-element
control. An
ABOVE_SCENEoverlay then redraws the wanted parts for exactlythose players.
Render callbacks from multiple plugins AND together, so this coexists with core
Entity Hider. The replacement overlay also mirrors Entity Hider's player
categories: if Entity Hider hides a player's model or 2D elements, this plugin
draws no replacement for that player.
Redrawn hitsplats reuse the active cache's own hitmark component sprites,
colours, movement, and fade timing. If a future cache revision can't be decoded
safely, that hitsplat falls back to a simple coloured marker.
On the third-party client rules
Flagging this up front, since prayer plugins get scrutiny and this one hides
information by default.
The banned category is anything that indicates which prayer to use — prayer
switching indicators, freeze timers, automatic stand-here tiles, resized prayer
book click zones. This plugin does none of that.
It only ever re-displays prayers that are already active and visible to
every client in the scene, restyled. It reads no state a vanilla player can't
already see, adds no timing or prediction, and never suggests an action. The
information content of the display is strictly a subset of what vanilla already
renders — by default it shows less, not more.
Precedent: core Entity Hider already hides player 2D elements including prayer
overheads, wholesale and with no replacement. Several hider plugins on the hub
do the same. This is the same operation with a cosmetic replacement layered
back on.
Demo
The clip below walks through each display mode with the config panel open,
starting with normal prayer and moving through the different options: overheads
hidden with tile replacement, character outline alone, compact overhead alone, and
all three combined (underfoot tile tint + outline + compact icon).
reworked_overheads.mp4
Notes for reviewers
com.prayeroverheadswhile the display name is"Overheads Reworked" — intentional, the plugin was renamed late and the
package was left stable.
handling. Slot assignment under multi-splat hits (dual-wield, Scythe, poison
landing alongside damage) is unit-tested; the drawing itself isn't, since it
needs a
Graphics2D, and has been checked in-game instead.