✨ Enable building mold with git reftable backend#1622
Open
Sylvyrfysh wants to merge 1 commit into
Open
Conversation
The git reftable backend mirrors the structure of the old backend, but only uses a binary table. This means that mold's current checks detect the git repository as intact, buta ttempt to read refs that do not exist. To fix this, first check if the HEAD points to "refs/heads/.invalid", which is how reftable is indicated without using the git CLI. Once we know we are in a reftable repo, use a new option, MOLD_NO_GIT, to gate attempts to find and use the Git executable. This enables us to attempt to use git while maintaing the same fallback paths of no hash if git is not present. Resolves: rui314#1621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The git reftable backend mirrors the file structure of the old backend, but only uses a binary table and removes .packed-refs. This means that mold's current checks detect the git repository as intact, but attempt to read refs that do not exist.
To fix this, first check if the HEAD points to "refs/heads/.invalid", which is how reftable is indicated without using the git CLI. Once we know we are in a reftable repo, use a new option, MOLD_NO_GIT, to gate attempts to find and use the Git executable. This enables us to attempt to use git while maintaining the same fallback paths of no hash if git is not present.
Resolves: #1621