Correct a bug when reading ntriples data that prevent to have values with "VERSION"#455
Open
decdocuteam wants to merge 1 commit intoruby-rdf:developfrom
Open
Correct a bug when reading ntriples data that prevent to have values with "VERSION"#455decdocuteam wants to merge 1 commit intoruby-rdf:developfrom
decdocuteam wants to merge 1 commit intoruby-rdf:developfrom
Conversation
|
|
mkllnk
approved these changes
Mar 24, 2026
mkllnk
left a comment
mkllnk
left a comment
There was a problem hiding this comment.
Nice work!
I'm just another user who's also looking forward to this project finding a new maintainer. I don't have any permissions here but I think that your contribution is great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently RDF::NTriples::Reader looks for RDF version information using the regexp /VERSION/, the problem is that it mess the parsing of triples containing the word VERSION like for example: "test_VERSION_test".
This PR correct the problem by looking for VERSION at the start of a line and not anywhere on the line.