RDF::Graph existence test methods generate unnecessary work#452
Merged
gkellogg merged 1 commit intoruby-rdf:developfrom May 12, 2025
Merged
RDF::Graph existence test methods generate unnecessary work#452gkellogg merged 1 commit intoruby-rdf:developfrom
RDF::Graph existence test methods generate unnecessary work#452gkellogg merged 1 commit intoruby-rdf:developfrom
Conversation
gkellogg
approved these changes
May 12, 2025
Member
gkellogg
left a comment
gkellogg
left a comment
There was a problem hiding this comment.
Thanks, there may be some other places in RDF::Graph, as it does have an odd relationship to RDF::Repository and the mixins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, just noticed a two-order-of-magnitude slowdown on
RDF::Graph#subject?etc. vs the same operation onRDF::Repository, because it inherits those methods fromRDF::Enumerable. I just popped in some short-circuited ones and the effect disappears.Since I'm in here though, are there any other methods I should be short-circuiting?