Skip to content

A leading -- is still dropped for mvnd, oc, sbt, gt, bun, deno, docker compose, go test/build/vet and kubectl get #4919

Open

Description

@KuSh

#4753 lists 19 commands whose leading -- clap strips before dispatch; #4768 restores it for those. The same loss happens on other passthrough arms the issue does not list.

argv a stub on PATH records for rtk <command> (develop 4b4bc40, and unchanged with #4768 merged):

command forwarded
rtk mvnd -- zzz zzz
rtk oc -- zzz zzz
rtk sbt -- zzz zzz
rtk gt -- zzz zzz
rtk bun -- zzz zzz
rtk deno -- zzz zzz
rtk docker compose -- zzz compose zzz
rtk go test -- zzz test -json zzz
rtk go build -- zzz build zzz
rtk go vet -- zzz vet zzz
rtk kubectl get -- zzz get zzz

The native command receives -- zzz in each case. mvnd shares mvn_cmd::run_tool with mvn, so after #4768 rtk mvn -- x and rtk mvnd -- x forward different argv.

Direction: the same dispatch-level restore as #4768 (restore_leading_double_dash in src/lib.rs), extended to these variants, with the restored -- placed after any option rtk injects (go test adds -json).

Activity

  1. rtk-wshm-sync-bot commented on Nov 1, 2026

    @rtk-wshm-sync-bot

    wshm · Automated triage by AI

    🔍 Automated Triage

    🐛 Category bug
    🟡 Priority medium
    🎯 Confidence 93%

    Summary

    Leading -- is dropped before dispatch for mvnd, oc, sbt, gt, bun, deno, docker compose, go test/build/vet, and kubectl get; extend restore_leading_double_dash in src/lib.rs to cover them.

    This looks like a simple fix that could be auto-resolved. Repo maintainers can use /wshm fix to attempt it.

    📁 Relevant files
    • src/lib.rs

    Suggested Actions

    1. Extend restore_leading_double_dash in src/lib.rs to cover the 11 listed commands, same pattern as fix(cli): restore a leading -- for 14 passthrough commands #4768
    2. Ensure the restored -- is placed after rtk-injected options (e.g. -json for go test)
    3. Add regression tests analogous to fix(cli): restore a leading -- for 14 passthrough commands #4768's for each listed passthrough arm (mvnd, oc, sbt, gt, bun, deno, docker compose…
    4. Cross-check mvn_cmd::run_tool so rtk mvn -- x and rtk mvnd -- x forward identical argv

    Triaged automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions