Addresses issue where styling is not applied to summary rows#2123
Open
thebioengineer wants to merge 2 commits intorstudio:masterfrom
Open
Addresses issue where styling is not applied to summary rows#2123thebioengineer wants to merge 2 commits intorstudio:masterfrom
thebioengineer wants to merge 2 commits intorstudio:masterfrom
Conversation
…ed to apply_cell_styles, and update .apply_style_alignment_shortstack to not fail if the entry is an empty character
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thank you for contributing to gt! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Resolves issue 2117, where when attempting to apply styling to a summary row led to an error because a grepl failed.
This highlighted a different issue where the "row_pos" was actually a double that was not the row position, but values like .999999999997, which is not an index, and when as.integteger is called on them, it becomes 0 (1.999999 becomes 1), etc.
This update forces the number to become an integer, and adds a protection in .apply_style_alignment_shortstack to not fail if the entry is an empty character
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.