-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[browser-client] add sequence id plugin #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Juice10
wants to merge
22
commits into
main
Choose a base branch
from
codex/browser-client-sequence-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
151d283
docs: add browser client sequence id design
Juice10 218f10b
docs: fix browser client sequence id design
Juice10 3ce7dfa
docs: remove tinybird reference from sequence id design
Juice10 5e4c156
docs: add browser client sequence id plan
Juice10 ae37b75
test: cover sequential id plugin options
Juice10 15aff98
test: cover default sequential id key
Juice10 795923b
feat: add sequential id plugin start options
Juice10 68bb276
test: cover browser client sequence ids
Juice10 dcc867f
chore: update sequential id plugin references
Juice10 8d2a85f
test: assert browser client sequence order
Juice10 1a559f1
test: observe pre-start browser client buffer
Juice10 459afa8
feat: add browser client sequence ids
Juice10 f490ae4
fix: prevent browser client sequence regressions
Juice10 96b7362
fix: sequence browser client custom events
Juice10 40983d9
test: assert browser client sequence ids
Juice10 1161544
docs: document browser client sequence ids
Juice10 59ce60d
Apply formatting changes
Juice10 0865ce8
Merge branch 'master' into codex/browser-client-sequence-id
Juice10 9a25441
fix: address browser client sequence id review
Juice10 349706f
Scope browser client start tokens by recording
Juice10 db92d8a
Invalidate start tokens without storage
Juice10 8495733
Avoid Array.from in start token fallback
Juice10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@rrweb/browser-client": patch | ||
| "@rrweb/rrweb-plugin-sequential-id-record": patch | ||
| --- | ||
|
|
||
| Add browser-client `sequenceId` assignment for Cloud-bound events and allow the sequential-id record plugin to resume from a provided starting ID. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be split in two changesets, one for browser-client, and one with the changes for the plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split into separate changesets in 9a25441: one for @rrweb/browser-client and one for @rrweb/rrweb-plugin-sequential-id-record.