Skip to content

Add action2idl script#654

Merged
sloretz merged 2 commits into
ros2:rollingfrom
Greek64:greek
Jul 11, 2022
Merged

Add action2idl script#654
sloretz merged 2 commits into
ros2:rollingfrom
Greek64:greek

Conversation

@Greek64

@Greek64 Greek64 commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Though the rosidl_adapter has scripts to generate IDL files from .msg and .srv files, a script for .action files is missing.
This PR rectifies that.

@hidmic hidmic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Greek64 LGTM overall, but I will point out that in Galactic and onwards, you can also do rosidl translate --to idl path/to/my.action

Comment thread rosidl_adapter/scripts/action2idl.py Outdated
@Greek64

Greek64 commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

@Greek64 LGTM overall, but I will point out that in Galactic and onwards, you can also do rosidl translate --to idl path/to/my.action

I didn't know that, thanks.
Is that documented anywhere?

@hidmic

hidmic commented Feb 17, 2022

Copy link
Copy Markdown
Contributor

Is that documented anywhere?

ros2/design#310 is probably the best place. Arguably, it should be replicated here.


CI up to rosidl_adapter:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@hidmic

hidmic commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

@Greek64 mind to alphabetise module import order? That should please flake8.

Signed-off-by: Greek64 <greek64.mail@gmail.com>
@Greek64

Greek64 commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

@hidmic Done.

@audrow
audrow changed the base branch from master to rolling June 28, 2022 14:23
@sloretz

sloretz commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

CI (repos file build: --packages-up-to rosidl_adapter test: --packages-select rosidl_adapter)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz sloretz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@sloretz

sloretz commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR!

@sloretz
sloretz merged commit 0250ae8 into ros2:rolling Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants