Complete Capsule export support and add public exportURDF API#256
Complete Capsule export support and add public exportURDF API#256saikishor wants to merge 1 commit into
Conversation
Signed-off-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
|
Needed for #230 |
| namespace urdf{ | ||
| URDFDOM_DLLAPI ModelInterfaceSharedPtr parseURDF(const std::string &xml_string); | ||
| URDFDOM_DLLAPI ModelInterfaceSharedPtr parseURDFFile(const std::string &path); | ||
| URDFDOM_DLLAPI std::string exportURDF(const ModelInterface &model); |
There was a problem hiding this comment.
I tthink they are used to export the string from a Model, but not much use. If this is the case, then there needs to be other cleanups to be done. Should I do the cleanup part?
There was a problem hiding this comment.
I don't think this is a breaking change, so we can merge to rolling after the freeze date and then backport to lyrical after the initial release
There was a problem hiding this comment.
I tthink they are used to export the string from a Model, but not much use. If this is the case, then there needs to be other cleanups to be done. Should I do the cleanup part?
maybe create an issue to describe the cleanup work to be done and what it will enable?
|
Tick the box to add this pull request to the merge queue (same as
|
2 participants
I was reviewing the changes of the Capsule geometry just in case before the official release, and I found that this geomtry is not exported anywhere. I added a utility here to finish that part