Skip to content

Add feedback callback#39

Open
mkrogius wants to merge 1 commit into
ros:indigo-develfrom
mcgill-robotics:indigo-devel
Open

Add feedback callback#39
mkrogius wants to merge 1 commit into
ros:indigo-develfrom
mcgill-robotics:indigo-devel

Conversation

@mkrogius

@mkrogius mkrogius commented Jun 6, 2015

Copy link
Copy Markdown

Adds a callback for the feedback from the action server. The callback is called with the userdata and the feedback message

@lgeo3

lgeo3 commented Feb 1, 2016

Copy link
Copy Markdown

Hi, is this pullrequest going to be accepted ? (I need the userdata in the feedback callback, and this commit seems to provide it)

@mkrogius

mkrogius commented Feb 4, 2016

Copy link
Copy Markdown
Author

Its been over a year and I haven't heard anything back, so I think its safe to assume its not going to happen.

@bajo

bajo commented Feb 4, 2016

Copy link
Copy Markdown

I fear the same, which is kind of sad, as this and some of the other open pull requests offer some nice additions so smach.
I for myself just cloned the executive_smach repo and merged the pull request into my local catkin workspace to be able to use them instead of the version that is released through the ros repository.

@lgeo3

lgeo3 commented Feb 5, 2016

Copy link
Copy Markdown

Ok, sad, @jbohren do you confirm ? Can we help you ?

@jbohren

jbohren commented Feb 5, 2016

Copy link
Copy Markdown
Member

@laurent-george et al. The real issue is a lack of time for thorough testing.

I've been meaning to get around to not only that things for a long time (as you can tell by messages on this project pages), but also migrate SMACH to use coroutines instead of threads.

AmandineMa added a commit to AmandineMa/executive_smach that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants