feat: add ERBLoader - #71
Closed
Rezenders wants to merge 15 commits into
Closed
Conversation
Author
Rezenders
marked this pull request as draft
August 5, 2026 00:04
Rezenders
marked this pull request as ready for review
August 5, 2026 18:31
Author
|
ready for review |
jhonasiv
requested review from
doudou and
jhonasiv
and removed request for
jhonasiv
August 7, 2026 12:21
doudou
reviewed
Aug 11, 2026
doudou
left a comment
doudou
left a comment
Contributor
There was a problem hiding this comment.
Need update after merging Loader and ERBLoader (probably the whole PR disappears, actually ?)
Author
Indeed, it disappears :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on rock-control/control-ruby_sdformat#40
Use
SDF::ERBLoaderrelated to PRs #69 #70