Use macros#2918
Conversation
Normative Rule Changes DetectedThis PR modifies normatively tagged text. Please review the changes below to ensure they are intentional. View Detected ChangesNormative Tag Change Reportriscv-spec SpecificationWhat happens next:
How to update reference files (if needed): make update-ref
git add ref/*.json
git commit -m "Update normative tag reference files"
This comment was automatically generated by the normative tag check workflow. |
1f6e8b8 to
aaa99fb
Compare
@jordancarlin @mmhus Could you check why this happens while the tag is not removed from the text? aaa99fb is the suspected commit. |
I think @rpsene is the one who created that workflow. Any ideas? |
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
@jordancarlin @mmhus @rpsene @aswaterman By doing |
|
OK, I found the difference. If a macro is used at the end of line inside a Normative Rule, the rule is dropped. NG: [#norm:zicntr_rdcycle_op]#The (...) of the csr:cycle[]
(...)OK: [#norm:zicntr_rdcycle_op]#The (...)
(...) of the csr:cycle[] (...)OK: [#norm:zicntr_rdcycle_op]#The (...) of the
csr:cycle[] (...)While we can avoid the bug easily, it would be better to fix. |
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
|
I will submit new PRs to avoid Norm tags conflicts. |
No description provided.