Skip to content

Remove go-git in admin driver#9519

Merged
k-anshul merged 5 commits into
mainfrom
remove_go_git_admin_driver
Jun 4, 2026
Merged

Remove go-git in admin driver#9519
k-anshul merged 5 commits into
mainfrom
remove_go_git_admin_driver

Conversation

@k-anshul
Copy link
Copy Markdown
Member

@k-anshul k-anshul commented Jun 3, 2026

Follow up with removal in other packages

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Jun 3, 2026
k-anshul added 2 commits June 3, 2026 15:58
- stabilize git env in Run (LC_ALL=C, GIT_TERMINAL_PROMPT=0)
- detect merge-in-progress via MERGE_HEAD instead of stderr substrings
- dedupe commitHash via gitutil.Hash, thread ctx through Hash
- drop redundant TrimSpace, decouple Clone from cwd
- add tests for conflict abort, missing-ref checkout, setGitConfig
@k-anshul k-anshul requested a review from begelundmuller June 3, 2026 12:57
Copy link
Copy Markdown
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-anshul k-anshul merged commit 8a6c6b8 into main Jun 4, 2026
11 of 12 checks passed
@k-anshul k-anshul deleted the remove_go_git_admin_driver branch June 4, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants