Issue 84 - #172
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @rubyAnneB on file. In order for us to review and merge your code, please visit https://dev.karakun.com/cla and follow the instructions on that page. |
sclassen
left a comment
sclassen
left a comment
There was a problem hiding this comment.
Thank you for this PR. There are some small changes needed.
Also please fill out the CLA
| @@ -21,6 +21,12 @@ dependencies { | |||
| implementation "org.testng:testng:$testngVersion" | |||
There was a problem hiding this comment.
Remove the testng dependency (and version variable) if it is no longer used
| @@ -14,4 +14,9 @@ | |||
| requires static java.servlet; | |||
| requires testng; | |||
There was a problem hiding this comment.
if testng is no longer used, then please remove it
There was a problem hiding this comment.
Would like me to delete everything relating to testng? Such as the SpringTestNGControllerTest?
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
2 participants
Added dependencies to the module, and converted SpringJUnitControllerTest.java, and JUnitDemoiTest.java to Junit 5. Closes #84