Repository navigation
Surface git clone/fetch progress and review commencement on stderr - #29
Conversation
…derr Co-authored-by: richardthombs <1511599+richardthombs@users.noreply.github.com>
richardthombs
left a comment
There was a problem hiding this comment.
All I see is the message
"Cloning into bare repository '/home/richard/.cache/prr/repos/azure-blackbird-blackbird.git'..."
There are none of the typical git clone progress messages updating throughout the cloning process.
…on non-TTY stderr Co-authored-by: richardthombs <1511599+richardthombs@users.noreply.github.com>
Fixed in commit
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Long-running
git clone --mirrorandgit remote updateoperations ran silently, giving users no feedback. The PR review engine also started without any indication, leaving users wondering if the process had stalled.Changes
internal/git/git.go: AddedStderr io.Writerfield toExecRunner. When set, git's stderr (clone/fetch progress lines) is tee'd viaio.MultiWriterto both the caller's writer and the internal capture buffer, preserving error message content.internal/git/mirror.go: Added--progressto all network-facing git operations to force git to emit full progress output even when stderr is not a TTY (which it isn't when piped viaio.MultiWriter). Also replacedgit remote update --prunewithgit fetch --all --prune --progresssincegit remote updatedoes not support--progress.cmd/prr/checkout_helpers.go:mirrorServiceFactorynow accepts anio.Writerso commands can injectcmd.ErrOrStderr()at creation time.cmd/prr/review.go: Passescmd.ErrOrStderr()to the factory and emits[prr] starting PR review...to stderr before invoking the review engine.cmd/prr/checkout.go,diff.go,pwd.go: Passcmd.ErrOrStderr()to the factory consistently.All feedback is written to stderr only — stdout piping for JSON/Markdown review output is unaffected.
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.