Skip to content

Fix Windows install.ps1 constructing incorrect release artifact filename - #27

Merged
richardthombs merged 2 commits into
mainfrom
copilot/fix-release-artifact-url
Mar 19, 2026
Merged

richardthombs merged 2 commits into
mainfrom
copilot/fix-release-artifact-url

Conversation

Copilot AI commented Mar 19, 2026 •

Copy link
Copy Markdown
Contributor

The GitHub release tag (v0.3.0) includes a v prefix, but release artifact filenames do not (prr_0.3.0_windows_amd64.zip). install.ps1 was using the raw tag name in the filename, producing a 404.

Changes

  • scripts/install.ps1: Strip the v prefix before constructing the archive filename, mirroring the existing pattern in install.sh:
# Before
$Archive = "${Binary}_${Version}_windows_${Arch}.zip"
# → prr_v0.3.0_windows_amd64.zip ❌

# After
$VersionNum = $Version -replace '^v', ''
$Archive = "${Binary}_${VersionNum}_windows_${Arch}.zip"
# → prr_0.3.0_windows_amd64.zip ✓

The download URL path still uses the full tag ($Version) — only the filename component is affected.

Original prompt

This section details on the original issue you should resolve

<issue_title>Windows install.ps1 gets release artifact URL wrong</issue_title>
<issue_description>It is attempting to download:
https://github.com/richardthombs/prr/releases/download/v0.3.0/prr_v0.3.0_windows_amd64.zip

But the release artifact is actually
https://github.com/richardthombs/prr/releases/download/v0.3.0/prr_0.3.0_windows_amd64.zip

Note that there is no "v" in front of the version number in the filename (but there is in the release path)</issue_description>

Comments on the Issue (you are @copilot in this section)


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

…ive filename

Co-authored-by: richardthombs <1511599+richardthombs@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Windows install.ps1 release artifact URL Fix Windows install.ps1 constructing incorrect release artifact filename Mar 19, 2026
Copilot AI requested a review from richardthombs March 19, 2026 16:46
@richardthombs
richardthombs marked this pull request as ready for review March 19, 2026 16:49
@richardthombs
richardthombs merged commit 30ce529 into main Mar 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows install.ps1 gets release artifact URL wrong

2 participants