Repository navigation
Replace single combined summary field with separate issueSummary and prSummary fields - #25
Merged
Merged
Conversation
- Replace single `Summary` field with `IssueSummary` and `PRSummary` in types.Review - Update AI prompt to request separate fields with explicit content constraints: issueSummary derived ONLY from linked issues prSummary derived ONLY from PR diff/changed files - Remove splitIssueAndPRSummaries/splitParagraphs helpers from render.go - Update renderMarkdown to use the new fields directly - Update whatIfReview to set the new fields - Update all tests to use the new field names and JSON keys Co-authored-by: richardthombs <1511599+richardthombs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue summary and PR summary duplication
Replace single combined summary field with separate issueSummary and prSummary fields
Mar 19, 2026
richardthombs
marked this pull request as ready for review
March 19, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue and PR summaries were generated from a single AI-produced string split by paragraph count — giving the AI no structural incentive to keep content separate, and routinely producing duplicate information in both sections.
Changes
types.Review— ReplaceSummary stringwithIssueSummaryandPRSummaryfields; validation requires both to be non-emptyengine.go) — Schema now requests two distinct fields with explicit content constraints:issueSummary: derived only from linked issues; must not reference the diffprSummary: derived only from the PR diff/changed files; must not reference issuesrender.go—renderMarkdownreads the fields directly; removessplitIssueAndPRSummariesandsplitParagraphswhatIfReview— Updated to populate both new fieldsissueSummary/prSummary{ "issueSummary": "...", "prSummary": "...", "risk": { ... }, "findings": [ ... ], "checklist": [ ... ] }Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/acme/repo/pulls/42/usr/bin/gh gh api repos/acme/repo/pulls/42 --jq .base.ref,.base.sha(http block)/usr/bin/gh gh api repos/acme/repo/pulls/42 --jq .base.ref,.base.sha 0.1-go1.25.0.lin--gdwarf-5 --global ux-amd64/pkg/tool/linux_amd64/cgo pull.rebase(http block)/usr/bin/gh gh api repos/acme/repo/pulls/42 --jq .base.ref,.base.sha _.a pto/tls/alert.go ux-amd64/pkg/tool/linux_amd64/compile pull.rebase(http block)https://api.github.com/repos/acme/repo/pulls/73/usr/bin/gh gh api repos/acme/repo/pulls/73 --jq .base.ref,.base.sha(http block)/usr/bin/gh gh api repos/acme/repo/pulls/73 --jq .base.ref,.base.sha _.a dor/golang.org/x/net/http/httpguts/guts.go ux-amd64/pkg/tool/linux_amd64/compile pull.rebase(http block)/usr/bin/gh gh api repos/acme/repo/pulls/73 --jq .base.ref,.base.sha ux-amd64/src/net --local /usr/local/bin/bash pull.rebase 5519(http block)https://api.github.com/repos/acme/repo/pulls/77/usr/bin/gh gh api repos/acme/repo/pulls/77 --jq .base.ref,.base.sha(http block)/usr/bin/gh gh api repos/acme/repo/pulls/77 --jq .base.ref,.base.sha /addrselect.go /cgo_unix.go ux-amd64/pkg/tool/linux_amd64/compile pull.rebase(http block)/usr/bin/gh gh api repos/acme/repo/pulls/77 --jq .base.ref,.base.sha ux-amd64/src/net-s DWaQSdYHv u/13/cc1 pull.rebase(http block)https://api.github.com/repos/checkouttestuser/checkouttestrepo/pulls/987654321/usr/bin/gh gh api repos/checkouttestuser/checkouttestrepo/pulls/987654321 --jq .base.ref,.base.sha(http block)/usr/bin/gh gh api repos/checkouttestuser/checkouttestrepo/pulls/987654321 --jq .base.ref,.base.sha 0.1-go1.25.0.lin--gdwarf-5 0.1-go1.25.0.lin--64 rg/toolchain@v0.-o pull.rebase(http block)/usr/bin/gh gh api repos/checkouttestuser/checkouttestrepo/pulls/987654321 --jq .base.ref,.base.sha ux-amd64/src/net-p --local ux-amd64/pkg/tool/linux_amd64/compile user.email(http block)https://api.github.com/repos/checkouttestuser2/checkouttestrepo2/pulls/123456789/usr/bin/gh gh api repos/checkouttestuser2/checkouttestrepo2/pulls/123456789 --jq .base.ref,.base.sha(http block)/usr/bin/gh gh api repos/checkouttestuser2/checkouttestrepo2/pulls/123456789 --jq .base.ref,.base.sha 0.1-go1.25.0.lin-pthread 0.1-go1.25.0.lin-Wl,--no-gc-sections rg/toolchain@v0.-fmessage-length=0 pull.rebase(http block)/usr/bin/gh gh api repos/checkouttestuser2/checkouttestrepo2/pulls/123456789 --jq .base.ref,.base.sha ux-amd64/src/net-p --local ux-amd64/pkg/tool/linux_amd64/link user.email(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.