Repository navigation
fix(player): hide virtual gamepad toolbar button on desktop - #287
Merged
Merged
Conversation
Reuse the existing desktop pointer mode so narrow PC windows also omit the virtual gamepad control. Preserve mobile toggling and cover both preference states and real RPG Maker launches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
提供虚拟手柄接口的核心在 PC 游玩时仍显示顶部手柄开关。复用 Player 现有的桌面指针判定,让 PC(含窄窗口)隐藏该按钮,移动触控设备继续显示并可切换。
同步 UI 契约和设计评审稿,并补充桌面偏好状态回归及实际 RPG Maker 四视口验证。
Evidence
After: 两项桌面断言通过,移动端开关及按核心保存偏好的测试继续通过;相关 21 项测试通过。
make web-check通过:样式门禁、lint、类型检查、590 项单测及生产构建。pfb-verify通过。Merge Danger
Door: two-way
Blast Radius: UI
影响普通 Player 顶部虚拟手柄按钮的渲染条件,可通过回退提交恢复。