Repository navigation
fix(saves): KiriKiri save thumbnails show the player's save point - #286
Merged
Merged
Conversation
A save update without a screenshot used to clear the stored image. Native GAME_SAVE runtimes now mark exports that only carry system files (UNCHANGED) or attach the save point's own image. The Host skips the current frame for UNCHANGED exports, uses a checkpoint's own image when present, and still captures the current frame for a record that has no image yet. The server keeps the current screenshot when an overwrite omits one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(saves)): an overwrite without a screenshot now keeps the stored image (previously it cleared it). The player host skips the current frame for checkpoints markedscreenshot: "UNCHANGED", uses a checkpoint's own save-point image when present, and still captures the current frame for a record that has no image yet. OpenAPI description,http-api-contract.mdand the Provider Module V1 authority (RuntimeCheckpointV1.screenshot?: Blob | "UNCHANGED") are updated.build(runtime)): ship retrom-runtimev0.94.0(Kiri Webretrom-core-g13dda190f837-r12) viamake runtime-provider-pin-release TAG=v0.94.0.Previously KiriKiri save cards were often black/dim or showed titles, save menus and confirmation dialogs: every native file write (system variables, the KAG start anchor during scene transitions) replaced the thumbnail with the frame on screen at that moment.
Validation
make backend-check,make web-check,make api-check,scripts/test_runtime_provider_contract.py, runtime contract snapshot check../internal/..., 19 packages) against an isolated database with the prepared v0.94.0 runtime/provider inputs; newTestSaveUpdateWithoutScreenshotKeepsCurrentImagefails without the service change.UNCHANGED, carried images and image-less records.🤖 Generated with Claude Code