Skip to content

remove deprecated /cluster-health#4781

Draft
muhamadazmy wants to merge 1 commit into
mainfrom
pr4781
Draft

remove deprecated /cluster-health#4781
muhamadazmy wants to merge 1 commit into
mainfrom
pr4781

Conversation

@muhamadazmy
Copy link
Copy Markdown
Contributor

remove deprecated `/cluster-health

Summary:
Fixes #3901

@muhamadazmy muhamadazmy requested a review from tillrohrmann May 21, 2026 10:38
@muhamadazmy muhamadazmy changed the title remove deprecated `/cluster-health remove deprecated /cluster-health May 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Test Results

  8 files  ± 0  8 suites  ±0   14m 46s ⏱️ + 9m 54s
 51 tests  -  9  0 ✅  -  60  0 💤 ±0  0 ❌ ±0   51 🔥 + 51 
238 runs   - 29  0 ✅  - 267  0 💤 ±0  0 ❌ ±0  238 🔥 +238 

For more details on these errors, see this check.

Results for commit 1bfae69. ± Comparison against base commit 98cfe09.

This pull request removes 14 and adds 5 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[1]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[2]
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)[3]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[1]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[2]
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)[3]
dev.restate.sdktesting.tests.Custom ‑ run(CustomTestConfig, URI, URI)[1]
…
dev.restate.sdktesting.tests.CallOrdering ‑ ordering(boolean[], Client)
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromAdminAPI(BlockingOperation, Client, URI)
dev.restate.sdktesting.tests.Cancellation ‑ cancelFromContext(BlockingOperation, Client)
dev.restate.sdktesting.tests.Custom ‑ run(CustomTestConfig, URI, URI)
dev.restate.sdktesting.tests.NonDeterminismErrors ‑ method(String, Client)

♻️ This comment has been updated with latest results.

Copy link
Copy Markdown
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the /cluster-health endpoint. LGTM. Please also add a release note. +1 for merging.

@tillrohrmann tillrohrmann added this to the 1.7 milestone May 22, 2026
@muhamadazmy
Copy link
Copy Markdown
Contributor Author

@slinkydeveloper and me thinks it's not the right time to introduce tests instabilities. Let's wait on this one and come back to it immediately after 1.7 release, so we have more time to change the tests and observe the results.

@muhamadazmy muhamadazmy marked this pull request as draft May 22, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cluster-health endpoint

2 participants