Implement Audio::GetVolumeFromTo (was a stub returning 0.0) - #106
Open
vjandrea wants to merge 1 commit into
Open
Implement Audio::GetVolumeFromTo (was a stub returning 0.0)#106vjandrea wants to merge 1 commit into
vjandrea wants to merge 1 commit into
Conversation
Maps the requested Hz range to FFT bin indices using `freqMax/fft.size()` and reduces them the same way `Update()` already does for the bass/med/high bands (square, apply gain, mean, sqrt). Range args are order-independent and clamped to the valid bin range, with the range always covering at least one bin. Also stops caching `freqBinStep` from `SetSampleRate`, since that could run before the first `Update()` call while `fft` was still empty `(freqMax / 0)`, and nothing recomputed it afterward if `fft`'s size changed. The equivalent bin step is now computed on demand from the always-current `fft.size()`. Fixes resolume#84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps the requested Hz range to FFT bin indices using
freqMax/fft.size()and reduces them the same wayUpdate()already does for the bass/med/high bands (square, apply gain, mean, sqrt). Range args are order-independent and clamped to the valid bin range, with the range always covering at least one bin.Also stops caching
freqBinStepfromSetSampleRate, since that could run before the firstUpdate()call whilefftwas still empty(freqMax / 0), and nothing recomputed it afterward iffft's size changed. The equivalent bin step is now computed on demand from the always-currentfft.size().Fixes #84