Skip to content

Fix swapped arguments for default build target list - #105

Open
vjandrea wants to merge 1 commit into
resolume:masterfrom
vjandrea:fix/swapped-arguments
Open

Fix swapped arguments for default build target list#105
vjandrea wants to merge 1 commit into
resolume:masterfrom
vjandrea:fix/swapped-arguments

Conversation

@vjandrea

@vjandrea vjandrea commented Aug 12, 2026

Copy link
Copy Markdown

The example plugins didn't build 'by default' without passing -DFFGL_BUILD_EXAMPLE_PLUGINS=ON explicitly.

When running cmake -S . -B build && cmake --build build --target help the ${FFGL_MASTER_PROJECT} toggle fell in the help text slot, and the docstring landed in the default argument, never evaluated as true, so the default plugins never appeared in the targets list.

With this change, the plugins show up :

cmake -S . -B build && cmake --build build --target help
-- The CXX compiler identification is GNU 13.3.0
...
... rebuild_cache
... ffgl-plugin-add
... ffgl-plugin-add-subtract
... ffgl-plugin-custom-thumbnails
... ffgl-plugin-events
... ffgl-plugin-gradients
... ffgl-plugin-particles
... ffgl-sdk
... source/lib/FFGLSDK.o
...

The example plugins didn't build 'by default' without passing `-DFFGL_BUILD_EXAMPLE_PLUGINS=ON`
explicitly. When running `cmake -S . -B build && cmake --build build --target help` the
`${FFGL_MASTER_PROJECT}` toggle fell in the help text slot, and the
docstring landed in the `default` argument, never evaluated as true, so
the default plugin never appeared in the targets list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant