Decode extended filenames for streamed downloads - #398
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
Honor encoded Content-Disposition filename parameters when inferring a download path, including fallback and directory stripping after decoding. Closes requests#379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads with a Content-Disposition
filename*parameter currently fail to infer a filename. Decode the declared charset and percent escapes, prefer a valid extended filename over the ordinary fallback regardless of order, and strip directory components after decoding. Malformed encodings fall back tofilename.Fixes #379. Follows RFC 6266 section 4.3.
Added coverage for UTF-8, ISO-8859-1, language tags, parameter casing, precedence, malformed values, encoded path separators/drive prefixes, and writing the downloaded content to the inferred Unicode filename. Nine regressions failed before implementation.
Validation:
git diff --checkpass. The test file retains two pre-existing style findings on unchanged lines.Disclosure: implemented and tested using OpenAI Codex in an authorized automated contribution session.