feat(ci): migrate to centralized reusable workflows#37
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Replaces all local CI/CD workflow definitions with thin callers to the org-wide reusable workflows in reqstool/.github. Changes: - build.yml: delegates lint to typescript/lint.yml@main and build (xvfb + reqstool install) to typescript/build.yml@main - release.yml: delegates to common/release.yml@main (semver format) - publish_vscode_ext.yml: delegates check-release, dry-run, and publish to centralized common/check-release and typescript/publish-to-vscode workflows; trigger changed from release: [created] to release: [published] (draft-gate pattern) - release-preview.yml: new workflow_dispatch caller to common/release-preview.yml@main Removed: - lint.yml: superseded by typescript/lint.yml@main - check_release.yml: publish workflow now calls centralized directly Closes reqstool/reqstool.github.io#33 (reqstool-vscode migration) Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
- Add prettier + eslint-config-prettier as dev dependencies - Add format and format:fix npm scripts - Add .prettierignore (excludes out/, node_modules/, *.vsix) - Wire eslint-config-prettier into eslint.config.mjs to prevent ESLint/Prettier rule conflicts - Format all existing source files with Prettier defaults CI now runs npm run format via typescript/lint.yml@main. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
jimisola
force-pushed
the
feat/use-centralized-workflows
branch
from
cd476b0 to
9ff53e8
Compare
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all CI/CD workflows to thin callers of the org-wide reusable workflows in
reqstool/.github(PR reqstool/.github#29).Replaced with centralized callers:
build.yml→typescript/lint.yml@main+typescript/build.yml@main(use-xvfb: true, reqstool install viadependency-version/dependency-install-command)release.yml→common/release.yml@main(version-format: semver)publish_vscode_ext.yml→common/check-release.yml@main+typescript/publish-to-vscode.yml@main; trigger changed fromrelease: [created]→release: [published](draft-gate pattern)New:
release-preview.yml—workflow_dispatchcaller tocommon/release-preview.yml@main; shows next version, draft notes, and the current npm package version for cross-checkDeleted:
lint.yml— superseded bytypescript/lint.yml@maincheck_release.yml— publish workflow now calls centralized directlyDependency
Requires reqstool/.github#29 to be merged before this PR's workflows will resolve.
Test plan
main—build.yml(lint + build with xvfb) andpublish_vscode_ext.ymldry-run both triggerrelease-preview.ymlviaworkflow_dispatch— confirm job summary renders with version table and draft notesrelease.ymlviaworkflow_dispatchwith a test version — confirm draft release is created (then delete it)