fix(ci): skip vscode publish steps when registry token is missing#33
Closed
jimisola wants to merge 1 commit into
Closed
fix(ci): skip vscode publish steps when registry token is missing#33jimisola wants to merge 1 commit into
jimisola wants to merge 1 commit into
Conversation
HaaLeo/publish-vscode-extension@v2 treats an empty `pat` as "not supplied" and errors out. Add a token-check step and gate each publish step on its output so the job succeeds gracefully when a registry secret (OPEN_VSX_TOKEN or VSCE_PAT) is not configured. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
Member
Author
|
Closing — the build should fail when a registry token is missing. The fix is to add the missing secret to the repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HaaLeo/publish-vscode-extension@v2treats an emptypatas "not supplied" and errors hard, even though both secrets (OPEN_VSX_TOKEN,VSCE_PAT) are declaredrequired: falseCheck token availabilitystep that writes boolean outputs by inspecting the secrets via env varsTest plan
Publish to Open VSX Registryinstead of erroring