fix(wagmi): respect coinbasePreference when selecting Coinbase connector#5665
Open
Khizr97 wants to merge 1 commit into
Open
fix(wagmi): respect coinbasePreference when selecting Coinbase connector#5665Khizr97 wants to merge 1 commit into
Khizr97 wants to merge 1 commit into
Conversation
Routes addThirdPartyConnectors based on coinbasePreference: 'smartWalletOnly' uses the baseAccount connector; 'all' and 'eoaOnly' use coinbaseWallet with the preference forwarded so QR code and EOA flows work correctly. Regression from PR #5269 which hardcoded baseAccount regardless of the option. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 934cd5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coinbasePreferencehas been silently ignored since PR feat: base account #5269 migrated to thebaseAccountconnector —baseAccountwas always used regardless of the option, breaking QR code and EOA flowsaddThirdPartyConnectorsnow routes based oncoinbasePreference:'smartWalletOnly'→baseAccount(passkey/smart wallet, no QR code)'all'or'eoaOnly'→coinbaseWalletwith the preference forwardedgetCoinbaseConnectornow accepts and passes thepreferenceparam tocoinbaseWallet({ preference })enableBaseAccount: false+coinbasePreference: 'smartWalletOnly'correctly falls back tocoinbaseWalletTest plan
coinbasePreference: 'all'→getCoinbaseConnectorcalled with'all',coinbaseWalletconnector addedcoinbasePreference: 'eoaOnly'→getCoinbaseConnectorcalled with'eoaOnly',coinbaseWalletconnector addedcoinbasePreference: 'smartWalletOnly'→getBaseAccountConnectorcalled,baseAccountconnector addedcoinbasePreference: 'smartWalletOnly'+enableBaseAccount: false→ falls back tocoinbaseWalletenableCoinbase: false→ no connector addedCloses REOWN-4407
🤖 Generated with Claude Code