Fixing issue with resolving indexes for Postgres.#329
Open
ViagioJustin wants to merge 1 commit intoreliese:v1.xfrom
Open
Fixing issue with resolving indexes for Postgres.#329ViagioJustin wants to merge 1 commit intoreliese:v1.xfrom
ViagioJustin wants to merge 1 commit intoreliese:v1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is happening on the MySQL as well but noticed when using this with Postgres that almost all generated relationships were
HasManyorBelongsToManyeven if there were unique keys or indexes.Best I could tell the regex for matching the index definitions was not matching a string like:
It seemed like the regex was expecting something like:
And maybe that's a MySQL syntax? Not sure. But changing the regex here seemed to correctly detect unique indexes and then bubbling up to the generator when determining if a relationship is a HasOne/BelongsTo or HasMany/BelongsToMany.