Expand Blueprint into DatabaseBlueprint, SchemaBlueprint, and TableBlueprint#201
Open
AdamLenda wants to merge 5 commits intoreliese:v1.xfrom
Open
Expand Blueprint into DatabaseBlueprint, SchemaBlueprint, and TableBlueprint#201AdamLenda wants to merge 5 commits intoreliese:v1.xfrom
AdamLenda wants to merge 5 commits intoreliese:v1.xfrom
Conversation
…o a Database, Schema and Table blueprint
| /** | ||
| * @var SchemaBlueprint[] | ||
| */ | ||
| private $schemaBlueprints; |
Member
There was a problem hiding this comment.
Even though PHP might work this way, we should give an initial value to our variables.
Suggested change
| private $schemaBlueprints; | |
| private $schemaBlueprints = []; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes extend the work that was done in https://github.com/reliese/laravel/pull/200/files
The new classes define a (hopefully) "idealized" representation of meta data from a database.
In the case of SchemaBlueprint it is a wrapper around a the existing Schema implementations.
The reason it is implemented as a "wrapper" is to ensure that previous implementations can be "adapted" to fit a new object model that organizes blueprints as a hierarchy of blueprints.
intended usage: