(Micro PR) Created DatabaseInterface and simple implementations#200
Open
AdamLenda wants to merge 4 commits intoreliese:v1.xfrom
Open
(Micro PR) Created DatabaseInterface and simple implementations#200AdamLenda wants to merge 4 commits intoreliese:v1.xfrom
AdamLenda wants to merge 4 commits intoreliese:v1.xfrom
Conversation
| 'mysql', | ||
| 'performance_schema', | ||
| ]); | ||
| return (new Database($connection))->getSchemaNames(); |
Member
There was a problem hiding this comment.
This method's cohesion is very low compared to the rest of the methods. It makes sense to put this logic elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first step towards isolating functionality that spans an entire database from the functionality that relates only to a schema within that data store.