fix(router): reject non-finite values in convertToNumberIfPossible#7457
Open
yashs33244 wants to merge 1 commit into
Open
fix(router): reject non-finite values in convertToNumberIfPossible#7457yashs33244 wants to merge 1 commit into
yashs33244 wants to merge 1 commit into
Conversation
…ossible The round-trip guard only checked that String(num) === value, which lets the strings "NaN", "Infinity" and "-Infinity" through as the non-finite numbers NaN/Infinity/-Infinity. This helper parses the currentPage and pageSize URL params and its result is typed as number | undefined, so a URL like ?currentPage=NaN produced a non-finite page number instead of leaving it as a string. Added a Number.isFinite check so only finite numeric strings convert.
🦋 Changeset detectedLatest commit: 3ed782a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convertToNumberIfPossibleparses URL pagination params (currentPage/pageSize, typednumber | undefined) with a round-trip guard`${num}` === value. BecauseString(NaN) === "NaN",String(Infinity) === "Infinity", etc., the inputs"NaN","Infinity","-Infinity"pass the guard and are returned as the non-finite JS numbers instead of strings — so?currentPage=NaNyields a non-finite "page number".This adds
Number.isFinite(num)to the guard. The helper is duplicated verbatim in three packages (react-router,remix-router,nextjs-router), all fixed. Adds the first vitest coverage for the helper in each package and apatchchangeset.Red-green proven; a 500k-input fuzz confirms behavior is identical to the old code for every finite value (zero regression).
biome+ per-packagetsc --noEmitclean.