Skip to content

fix(e2e): use translated sidebar text for Extensions in localization tests #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zdrapela wants to merge 1 commit into from
Closed

fix(e2e): use translated sidebar text for Extensions in localization tests #4512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions e2e-tests/playwright/e2e/extensions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@
await uiHelper.openSidebarButton(
t["rhdh"][lang]["menuItem.administration"],
);
// TODO: https://issues.redhat.com/browse/RHDHBUGS-2782
// await uiHelper.openSidebar(t["plugin.extensions"][lang]["header.title"]);
await uiHelper.openSidebar("Extensions");
await uiHelper.openSidebar(t["rhdh"][lang]["menuItem.extensions"]);
await uiHelper.verifyHeading(
t["plugin.extensions"][lang]["header.extensions"],
);
Expand Down Expand Up @@ -396,7 +394,7 @@
await page.keyboard.press(`${modifier}+KeyA`);
await page.keyboard.press(`${modifier}+KeyV`);
await uiHelper.verifyText("pluginConfig:");
await page.locator(".copy-button").first().click();

Check warning on line 397 in e2e-tests/playwright/e2e/extensions.spec.ts

View workflow job for this annotation

GitHub Actions / TSC, ESLint and Prettier 

Usage of raw locator detected. Use methods like .getByRole() or .getByText() instead of raw locators
await expect(
page.getByRole("button", { name: "✔" }).nth(0),
).toBeVisible();
Expand Down
Loading