Skip to content

Better LinkType support#2987

Merged
cmelchior merged 5 commits into
developfrom
cm/better_linktype_support
Jan 29, 2018
Merged

Better LinkType support#2987
cmelchior merged 5 commits into
developfrom
cm/better_linktype_support

Conversation

@cmelchior
Copy link
Copy Markdown
Contributor

@cmelchior cmelchior commented Jan 26, 2018

A few small changes for making it easier for Object Store to adopt cascading deletes (weak/strong links). See realm/realm-object-store#622

@cmelchior cmelchior self-assigned this Jan 26, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 26, 2018 •
edited
Loading

Codecov Report

Merging #2987 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2987      +/-   ##
===========================================
+ Coverage    93.16%   93.16%   +<.01%     
===========================================
  Files          257      257              
  Lines        77130    77151      +21     
===========================================
+ Hits         71855    71876      +21     
  Misses        5275     5275
Impacted Files Coverage Δ
src/realm/table.hpp 97.39% <ø> (ø) ⬆️
test/test_table.cpp 99.76% <100%> (ø) ⬆️
src/realm/table.cpp 90.81% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727e935...f2fe892. Read the comment docs.

@realm-ci
Copy link
Copy Markdown
Contributor

realm-ci commented Jan 26, 2018

Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2987/1/Performance_Report

@realm-ci
Copy link
Copy Markdown
Contributor

realm-ci commented Jan 26, 2018

Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2987/2/Performance_Report

ironage
ironage approved these changes Jan 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test0 file is still added to git. Please git rm -r cmake-build-debug
Otherwise 👍

Comment thread CHANGELOG.md Outdated
### Enhancements

* None.
* Added `Tabe::get_link_type()` as a helper method for getting the link type from link columns.
Copy link
Copy Markdown
Contributor

@ironage ironage Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp: Tabe->Table
A nice to have is also to include: PR [#2987](https://github.com/realm/realm-core/pull/2987).

@realm-ci
Copy link
Copy Markdown
Contributor

realm-ci commented Jan 26, 2018

Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2987/3/Performance_Report

@cmelchior cmelchior merged commit 108a4b8 into develop Jan 29, 2018
@cmelchior cmelchior deleted the cm/better_linktype_support branch January 29, 2018 15:42
jedelbo pushed a commit that referenced this pull request Mar 5, 2018
@cmelchior @jedelbo
Better LinkType support (#2987)
2cd40be
jedelbo added a commit that referenced this pull request Mar 5, 2018
@jedelbo
Merge pull request #3010 from realm/better-linktype-support
f6aa47f 
Better LinkType support (#2987)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ironage ironage ironage approved these changes

+1 more reviewer

@finnschiermer finnschiermer finnschiermer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmelchior cmelchior

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cmelchior @codecov-io @realm-ci @ironage @finnschiermer