[R4_4][IMessageControl] Backporting#495
Open
VeithMetro wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR backports updates to the Exchange::IMessageControl interface to align it with newer Thunder messaging metadata and JSON-RPC generation expectations.
Changes:
- Replaces the local
messagetypeenum withCore::Messaging::Metadata::typeand adds a JSON annotation/version line. - Switches interface method return types from
uint32_ttoCore::hresult. - Adds a
Modules()property and changesControls()to be module-indexed (module-specific controls).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tral/ThunderInterfaces into development/messaging-backporting
| virtual Core::hresult Controls(const string& module /* @index @optional */, IControlIterator*& control /* @out */) const = 0; | ||
|
|
||
| // @json:omit | ||
| virtual Core::hresult Controls(IControlIterator*& controls) const = 0; |
Contributor
Author
There was a problem hiding this comment.
@sebaszm we have @json:omit here, but does /* @out */ perhaps have any effect on the COM-RPC?
sebaszm
approved these changes
May 9, 2026
MFransen69
requested changes
May 9, 2026
MFransen69
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.