feat: add ContentHash and KeyAuthor fields for move/rename support#4
Open
mcanevet wants to merge 2 commits intorclone:masterfrom
Open
feat: add ContentHash and KeyAuthor fields for move/rename support#4mcanevet wants to merge 2 commits intorclone:masterfrom
mcanevet wants to merge 2 commits intorclone:masterfrom
Conversation
…oint
Proton's storage backend now requires a Verifier.Token per block when
requesting block upload URLs (POST /drive/blocks). Without it, the storage
server rejects uploads with HTTP 422 / Code=200501 "Operation failed:
Please retry".
This commit adds:
- RevisionVerification type and BlockUploadVerifier type in block_types.go
- Verifier field (omitempty) on BlockUploadInfo
- GetRevisionVerification() method calling the v2 API endpoint:
GET /drive/v2/volumes/{volumeID}/links/{linkID}/revisions/{revisionID}/verification
The VerificationCode returned by that endpoint is XOR'd with the leading
bytes of each block's ciphertext in Proton-API-Bridge to produce the
per-block token (matching the algorithm in the official Proton Drive JS SDK).
Note: the JS SDK also decrypts each block as a client-side integrity check
before computing the XOR. That step is not implemented here; the server-side
manifest signature still provides end-to-end integrity verification.
This fix was identified and generated with Claude Code (AI assistant) by a
non-programmer user. It has not been independently reviewed by a Go or
cryptography expert. Expert review before merging is strongly recommended.
Fixes uploads failing with: 422 POST fra-storage.proton.me/storage/blocks:
Operation failed: Please retry (Code=200501, Status=422)
- Add ContentHash *string field to MoveLinkReq (nil serializes as JSON null) - Add KeyAuthor *string field to Link struct (for anonymous node detection) These changes fix Code 2000 errors during move/rename operations by: 1. Allowing explicit null ContentHash to be sent for file moves 2. Allowing detection of anonymous vs non-anonymous nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ContentHash and KeyAuthor fields to fix Code 2000 errors during move/rename operations.
Changes
ContentHash *stringfield toMoveLinkReq(nil serializes as JSON null)KeyAuthor *stringfield toLinkstruct (for anonymous node detection)Why
These changes fix Code 2000 errors during move/rename operations by:
Test Results
With the companion Proton-API-Bridge fix:
See also: rclone/Proton-API-Bridge#3