-
Notifications
You must be signed in to change notification settings - Fork 8k
[core] Unify RuntimeEnv archive validation and support tar.xz #65742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhjwpku
wants to merge
2
commits into
ray-project:master
Choose a base branch
from
zhjwpku:runtime-env-tar-xz-65738
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| from typing import Dict, Optional, Tuple | ||
|
|
||
| WORKING_DIR = "working_dir" | ||
| PY_MODULES = "py_modules" | ||
|
|
||
| ZIP_EXTENSION = ".zip" | ||
| WHEEL_EXTENSION = ".whl" | ||
| JAR_EXTENSION = ".jar" | ||
| TAR_GZ_EXTENSION = ".tar.gz" | ||
| TGZ_EXTENSION = ".tgz" | ||
| TAR_BZ2_EXTENSION = ".tar.bz2" | ||
| TAR_XZ_EXTENSION = ".tar.xz" | ||
|
|
||
| # These are the user-facing formats accepted for RuntimeEnv package fields. | ||
| # Keep field-specific validation, local uploads, and Job package uploads derived | ||
| # from this mapping so they cannot silently diverge. | ||
| RUNTIME_ENV_PACKAGE_EXTENSIONS: Dict[str, Tuple[str, ...]] = { | ||
| WORKING_DIR: ( | ||
| ZIP_EXTENSION, | ||
| TAR_GZ_EXTENSION, | ||
| TGZ_EXTENSION, | ||
| TAR_XZ_EXTENSION, | ||
| ), | ||
| PY_MODULES: ( | ||
| ZIP_EXTENSION, | ||
| WHEEL_EXTENSION, | ||
| TAR_GZ_EXTENSION, | ||
| TGZ_EXTENSION, | ||
| TAR_XZ_EXTENSION, | ||
| ), | ||
| } | ||
|
|
||
| PACKAGE_UPLOAD_EXTENSIONS = tuple( | ||
| dict.fromkeys( | ||
| extension | ||
| for extensions in RUNTIME_ENV_PACKAGE_EXTENSIONS.values() | ||
| for extension in extensions | ||
| ) | ||
| ) | ||
|
|
||
| # .tar.bz2 is retained as a low-level download format for compatibility, but it | ||
| # is not part of the public working_dir or py_modules contract above. | ||
| TAR_EXTENSIONS = ( | ||
| TAR_GZ_EXTENSION, | ||
| TGZ_EXTENSION, | ||
| TAR_BZ2_EXTENSION, | ||
| TAR_XZ_EXTENSION, | ||
| ) | ||
| COMPOUND_ARCHIVE_EXTENSIONS = ( | ||
| TAR_GZ_EXTENSION, | ||
| TAR_BZ2_EXTENSION, | ||
| TAR_XZ_EXTENSION, | ||
| ) | ||
|
|
||
|
|
||
| def get_package_extension( | ||
| path: str, supported_extensions: Tuple[str, ...] | ||
| ) -> Optional[str]: | ||
| """Return the supported extension for a package path. | ||
|
|
||
| Args: | ||
| path: Package path or URI to inspect. | ||
| supported_extensions: Extensions to match in any order, including compound | ||
| extensions. If extensions overlap, the longest match takes precedence. | ||
|
|
||
| Returns: | ||
| The longest matching extension, or ``None`` if the path is unsupported. | ||
| """ | ||
| for extension in sorted(supported_extensions, key=len, reverse=True): | ||
| if path.endswith(extension): | ||
| return extension | ||
| return None | ||
|
|
||
|
|
||
| def has_package_extension(path: str, supported_extensions: Tuple[str, ...]) -> bool: | ||
| """Return whether a package path ends in a supported extension.""" | ||
| return get_package_extension(path, supported_extensions) is not None | ||
|
|
||
|
|
||
| def validate_package_extension( | ||
| path: str, field: str, display_path: Optional[str] = None | ||
| ) -> None: | ||
| """Validate a RuntimeEnv package path using the field's capabilities. | ||
|
|
||
| Args: | ||
| path: Package path to validate. | ||
| field: RuntimeEnv field whose format capabilities apply. | ||
| display_path: Optional sanitized user-facing path to include in validation | ||
| errors. URI query parameters must be removed before passing it. | ||
|
|
||
| Raises: | ||
| ValueError: If the path does not have an extension supported by the field. | ||
| """ | ||
| supported_extensions = RUNTIME_ENV_PACKAGE_EXTENSIONS[field] | ||
| if has_package_extension(path, supported_extensions): | ||
| return | ||
|
|
||
| formats = ", ".join(supported_extensions) | ||
| error_path = path if display_path is None else display_path | ||
| raise ValueError( | ||
| f"Only {formats} files are supported for {field} URIs; got {error_path}." | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.