Skip to content

Fix for queries with invalid characters#502

Merged
hmusta merged 11 commits into
masterfrom
sshash_query_fixes
Oct 8, 2024
Merged

Fix for queries with invalid characters#502
hmusta merged 11 commits into
masterfrom
sshash_query_fixes

Conversation

@hmusta

@hmusta hmusta commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

Changes:

  • Pre-encode query sequences to discard invalid characters
  • Add AnnotatedDBG and LabeledAligner tests with DBGSSHash to test annotated graph queries

Comment thread metagraph/src/graph/representation/canonical_dbg.cpp
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.hpp Outdated
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.cpp Outdated
Comment thread metagraph/tests/graph/all/test_dbg_helpers.cpp Outdated
Comment thread metagraph/tests/graph/all/test_dbg_helpers.cpp Outdated
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.cpp
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.cpp Outdated
@hmusta hmusta requested a review from adamant-pwn October 8, 2024 21:02
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.cpp Outdated
Comment thread metagraph/src/graph/representation/hash/dbg_sshash.cpp Outdated

@adamant-pwn adamant-pwn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hmusta hmusta merged commit 5af4aca into master Oct 8, 2024
@hmusta hmusta deleted the sshash_query_fixes branch October 8, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants