Skip to content

Sshash module superkmer anno#497

Closed
adamant-pwn wants to merge 56 commits into
masterfrom
sshash_module_superkmer_anno
Closed

Sshash module superkmer anno#497
adamant-pwn wants to merge 56 commits into
masterfrom
sshash_module_superkmer_anno

Conversation

@adamant-pwn

Copy link
Copy Markdown
Member

Pull request to track merging of further changes from @mmarzett.

@adamant-pwn adamant-pwn requested a review from hmusta July 25, 2024 15:04
@adamant-pwn

Copy link
Copy Markdown
Member Author

Also see ratschlab/sshash#10 for related changes in sshash repo.

@hmusta

hmusta commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

As mentioned during a previous meeting, I think annotating based on monotigs (monochromatic contigs) makes more sense. I've started an implementation at #500. Are there any fixes from the sshash library used here that we should port over there?

@adamant-pwn

Copy link
Copy Markdown
Member Author

I'm not very familiar with this branch, and my fixes mostly were to properly merge changes from #481 into it and make sure it still compiles and passes current tests. Is #500 implemented fully from scratch without relying on the content of this branch? If so, we can drop this branch, I suppose.

@hmusta

hmusta commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

I'm not very familiar with this branch, and my fixes mostly were to properly merge changes from #481 into it and make sure it still compiles and passes current tests. Is #500 implemented fully from scratch without relying on the content of this branch? If so, we can drop this branch, I suppose.

Yes, it's implemented from scratch. So I'll close this.

@hmusta hmusta closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants