switch from 'cuda-python' to specific components (e.g. 'cuda-bindings')#8314
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
📝 WalkthroughWalkthroughThis PR replaces the Changescuda-python to cuda-bindings migration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dependencies.yaml (1)
745-756: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRename the selector to match
cuda-bindings
If this block now installscuda-bindings,depends_on_cuda_pythonis misleading. Rename it todepends_on_cuda_bindingsand update theincludes:references in this file.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@dependencies.yaml` around lines 745 - 756, The selector name in the cuda-python dependency block no longer matches the package it installs. Rename depends_on_cuda_python to depends_on_cuda_bindings in the dependency definition, and update every includes reference in this file that points to the old selector so they resolve to the new name. Keep the matrix/package entries in that block unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@dependencies.yaml`:
- Around line 745-756: The selector name in the cuda-python dependency block no
longer matches the package it installs. Rename depends_on_cuda_python to
depends_on_cuda_bindings in the dependency definition, and update every includes
reference in this file that points to the old selector so they resolve to the
new name. Keep the matrix/package entries in that block unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 94a29e83-6641-4139-944f-5af68bd56602
📒 Files selected for processing (7)
conda/environments/all_cuda-129_arch-aarch64.yamlconda/environments/all_cuda-129_arch-x86_64.yamlconda/environments/all_cuda-133_arch-aarch64.yamlconda/environments/all_cuda-133_arch-x86_64.yamlconda/recipes/cuml/recipe.yamldependencies.yamlpython/cuml/pyproject.toml
|
/merge |
Description
Contributes to rapidsai/build-planning#285
cuda-pythonis a metapackage and sometimes pulls in components that RAPIDS libraries don't need. This PR is part of a series dropping direct use ofcuda-pythonin favor of depending only on those specific components.cuda-pythoncuda-bindings >=12.9.2,<13.0(CUDA 12),cuda-bindings >=13.0.1,<14.0(CUDA 13)cuda-bindingsin CINotes for Reviewers
Why these specific bounds?
cuda-pythoncuda-bindingsmajor version follows the CTK major version, so kept a ceiling just like we currently have forcuda-pythonThis PR has dependencies