support positive count in Readdir()#61
Merged
Merged
Conversation
Contributor
|
I confirmed this pull-request fixes both problem. Current implementation of Readdir return all of files in the directory.
About problem that Name() return absolute path, this is not a big problem since most of users does not call Name() in the fs. If someone got this bug, they had report already. @rakyll I'm looking for fixing this issue. Could you please take a look? |
Contributor
Author
|
How about it? @rakyll |
rakyll
reviewed
Mar 13, 2019
Fix error messages and variable names.
Contributor
Author
|
Thank you for the kind reviews. |
rakyll
approved these changes
Mar 20, 2019
Owner
|
Thanks much. |
This was referenced Mar 20, 2019
Closed
Contributor
Author
|
Thank you, too! |
ekanna
pushed a commit
to ekanna/statik
that referenced
this pull request
Sep 12, 2019
Follow on rakyll#60. The Readdir() should support positive count in order to return the specified counts of files. For it, I defined statikFS.dirs and httpFile.dirIdx for managing the internal state and use it inside Readdir().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow on #60.
The Readdir() should support positive
countin order to return the specified counts of files.For it, I defined statikFS.dirs and httpFile.dirIdx for managing the internal state and use it inside Readdir().