feature: staking earnings decimal formatting design#7358
Merged
Conversation
|
🧪 Flashlight Performance Report (AWS Device Farm) 🔀 Commit: bbe8ef3
|
i1skn
reviewed
Apr 17, 2026
| @@ -0,0 +1,15 @@ | |||
| export function parseDecimalParts(value: string): { | |||
Contributor
There was a problem hiding this comment.
can we have a couple of unit tests for this helper?
i1skn
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3640
What changed
RnbwStakingEarningsCard: Changed style of decimal portion of earnings number.parseDecimalParts: Helper for splitting the number between integer portion and decimal portion for formatting the text differently. Note that we force US-locale style comma/decimal separators across the app so the simplistic splitting by "." logic works here.Screen recordings / screenshots