chore: pin @ledgerhq/logs to a single version#7355
Merged
janicduplessis merged 1 commit intodevelopfrom Apr 17, 2026
Merged
Conversation
janicduplessis
force-pushed
the
@janic/pin-ledgerhq-logs-resolution
branch
from
210e076 to
e7e3218
Compare
Adds an explicit yarn resolution for @ledgerhq/logs. Without this, yarn can end up with multiple versions of @ledgerhq/logs hoisted into node_modules when dependencies are updated (different ledgerhq packages specify different semver ranges), which produces two separate LocalTracer class definitions with incompatible private fields and breaks src/utils/ledger.ts under tsc. This should have been added alongside the ble-plx / hw-transport-ble bump in #7323 β the next dep bump that touches anything ledgerhq-adjacent will re-introduce the duplicate otherwise.
janicduplessis
force-pushed
the
@janic/pin-ledgerhq-logs-resolution
branch
from
e7e3218 to
75bbf34
Compare
|
π§ͺ Flashlight Performance Report (AWS Device Farm) π Commit: 5041dd3 π View Artifacts
|
olerass
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Adds an explicit yarn resolution for
@ledgerhq/logspinned to6.16.0β the version already resolved on develop today. This is strictly a pin, not a bump: no package version changes, just making the existing resolution explicit so future dep updates can't split it.Without this pin, yarn can end up with multiple versions of
@ledgerhq/logshoisted intonode_moduleswhen dependencies are updated, because different ledgerhq packages specify different semver ranges. When that happens, TypeScript sees two separate declarations of theLocalTracerclass with incompatible private fields, andsrc/utils/ledger.tsfails to type-check with:This should have been added alongside the ble-plx / hw-transport-ble bump in #7323 β the next dep bump that touches anything ledgerhq-adjacent will re-introduce the duplicate otherwise. Surfacing it as a standalone PR so it's easy to review and doesn't get lost inside an unrelated bump.
Screen recordings / screenshots
N/A β resolutions-only change.
What to test
yarn installcompletes without warnings about the ledger stackyarn lint:tspasses (in particular, noBleTransport/LocalTracererrors insrc/utils/ledger.ts)