fix: remove dead TransactionDetailsAddressRow and fix ContextMenu import in ENSIntroSheet#7338
Merged
janicduplessis merged 2 commits intodevelopfrom Apr 14, 2026
Merged
Conversation
|
🧪 Flashlight Performance Report (AWS Device Farm) 🔀 Commit: fdbc038
|
Contributor
|
It looks like Also, |
janicduplessis
changed the title
Contributor
Author
|
Good catch on both! Removed the dead |
…dressRow Import ContextMenu from the barrel export instead of directly from the .android file. Direct platform-specific imports bypass RN's platform resolution which is required for new arch.
…ort in ENSIntroSheet TransactionDetailsAddressRow is dead code (not imported anywhere). ENSIntroSheet has the same direct .android import that bypasses RN platform resolution, which is required for new arch.
janicduplessis
force-pushed
the
@janic/fix-context-menu-import
branch
from
0a10b75 to
e167da8
Compare
olerass
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-3623
What changed (plus any additional context for devs)
Extracted from the new arch migration PR #6924.
TransactionDetailsAddressRow— it's dead code, not imported anywhereENSIntroSheetwhich has the same direct.androidContextMenu import that bypasses RN platform resolution, which is required for new archWhat to test
Code only change