fix: replace dispatchCommand with runOnJS for browser search input focus#7337
fix: replace dispatchCommand with runOnJS for browser search input focus#7337janicduplessis merged 2 commits intodevelopfrom
Conversation
…search Replace `dispatchCommand(inputRef, 'focus')` with `runOnJS` callback to focus the input from a worklet. `dispatchCommand` is not compatible with the new architecture for this use case. Also use `TAB_BAR_HEIGHT` consistently for both platforms instead of hardcoding 46 for Android.
|
🧪 Flashlight Performance Report (AWS Device Farm) 🔀 Commit: 88505da
|
|
Validated on iOS and Android emulator |
|
Can we split this PR out? It's changing two fundamentall independent things with no functional relation except they happen to be in the same file. Also the dispatch fix is required and thus related to the new arch migration, the tab bar height is just regular bug with no releation (right)? The dispatchCommand fix looks clean and ready to ship. The tab bar height fix is a visual change that could use before/after screenshots to explain what's going on. I captured these to understand it (feel free to use, but it's only showing gesture nav, we should also check 3 button nav case): 
|
Revert the TAB_BAR_HEIGHT change — it's an independent visual fix unrelated to the dispatchCommand migration and should be reviewed separately.
|
Split the tab bar height fix into a separate PR: #7345. This PR now only contains the |
2 participants
Fixes APP-3622
What changed (plus any additional context for devs)
Extracted from the new arch migration PR #6924.
The browser search bar uses Reanimated's
dispatchCommand(inputRef, 'focus')to focus the text input from a worklet.dispatchCommandrelies on the legacy Paper command dispatch mechanism which is not available on new arch (Fabric).Replaces with a
runOnJScallback that callsinputRef.current?.focus()on the JS thread — the standard pattern for triggering imperative methods from worklets.What to test